Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve translation in packages #600

Merged
merged 13 commits into from
Jan 15, 2025

Conversation

0xAlunara
Copy link
Collaborator

@0xAlunara 0xAlunara commented Jan 14, 2025

Moving some package dependencies around to curve-ui-kit and having a shared lingui config file.

Depends on #598

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
curve-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 6:30pm
curve-dapp-crvusd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 6:30pm
curve-dapp-dao ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 6:30pm
curve-dapp-lend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 6:30pm
curve-dapp-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 6:30pm

Copy link
Contributor

@DanielSchiavini DanielSchiavini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a bad idea to move devDependencies to dependencies but I don't see a difference in the bundle size

apps/dao/lingui.config.ts Outdated Show resolved Hide resolved
apps/lend/package.json Outdated Show resolved Hide resolved
packages/ui/src/utils/utilsFormat.ts Outdated Show resolved Hide resolved
apps/lend/lingui.config.ts Outdated Show resolved Hide resolved
@0xAlunara 0xAlunara merged commit cf23f0f into main Jan 15, 2025
11 checks passed
@0xAlunara 0xAlunara deleted the refactor/translations-monorepo branch January 15, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants